Re: [PATCH 17/19] can: sun4i_can: Convert to platform remove callback returning void
From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2023-05-13 06:37:06
Also in:
linux-can, linux-sunxi
From: Jernej Škrabec <jernej.skrabec@gmail.com>
Date: 2023-05-13 06:37:06
Also in:
linux-can, linux-sunxi
Dne petek, 12. maj 2023 ob 23:27:23 CEST je Uwe Kleine-König napisal(a):
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <redacted>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej