Hi Vladimir,

Hello Lukasz,

On Mon, May 29, 2023 at 11:02:22AM +0200, Lukasz Majewski wrote:

quoted

Dear All,
  

quoted

After the commit (SHA1: 7e9517375a14f44ee830ca1c3278076dd65fcc8f);
"net: dsa: mv88e6xxx: fix max_mtu of 1492 on 6165, 6191, 6220,
6250, 6290" the error when mv88e6020 or mv88e6071 is used is not
present anymore.
  

Are there any more comments for this patch set?  

Has your email client eaten these comments too?

https://lore.kernel.org/netdev/c39f4127-e1fe-4d38-83eb-f372ca2ebcd3@lunn.ch/ (local)
| On Wed, May 24, 2023 at 03:48:02PM +0200, Andrew Lunn wrote:
| > > > Vladimir indicates here that it is not known how to change
the max MTU | > > > for the MV88E6250. Where did you get the
information from to implement | > > > it?
| > > 
| > > Please refer to [1].
| > > 
| > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
| > > registers' offsets and bits are the same for mv88e60{71|20}).
| > 
| > So you have the datasheet? You get the information to implement
this | > from the data sheet?
| > 

This I've replied to Andrew in a private mail.

| >      Andrew

https://lore.kernel.org/netdev/ZG4E+wd03cKipsib@shell.armlinux.org.uk/ (local)
| On Wed, May 24, 2023 at 01:37:15PM +0100, Russell King (Oracle)
wrote: | > On Wed, May 24, 2023 at 02:17:43PM +0200, Lukasz Majewski
wrote: | > > Please refer to [1].
| > > 
| > > The mv88e6185_g1_set_max_frame_size() function can be reused (as
| > > registers' offsets and bits are the same for mv88e60{71|20}).
| > > 
| > > After using Vladimir's patch there is no need to add max_frame
size | > > field and related patches from v6 can be dropped.
| > 
| > However, you haven't responded to:
| > 
| >
https://lore.kernel.org/all/ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk/ (local) |

quoted

| > to explain why what you're doing (adding this function) is safe.

| > 
| > Thanks.
| > 

The above question has been replied:
https://lore.kernel.org/all/20230524145357.3928f261@wsk/ (local)

| > -- 
| > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
| > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Do you have any more comments?


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de