Re: [PATCH net-next v4 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

On Tue, May 23, 2023 at 3:55 PM Conor Dooley [off-list ref] wrote:

Hey Justin,

On Tue, May 23, 2023 at 02:53:43PM -0700, Justin Chen wrote:

quoted

+  compatible:
+    enum:
+      - brcm,asp-v2.0
+      - brcm,bcm72165-asp
+      - brcm,asp-v2.1
+      - brcm,bcm74165-asp

quoted

+        compatible = "brcm,bcm72165-asp", "brcm,asp-v2.0";

You can't do this, as Rob's bot has pointed out. Please test the
bindings :( You need one of these type of constructs:

compatible:
  oneOf:
    - items:
        - const: brcm,bcm72165-asp
        - const: brcm,asp-v2.0
    - items:
        - const: brcm,bcm74165-asp
        - const: brcm,asp-v2.1

Although, given either you or Florian said there are likely to be
multiple parts, going for an enum, rather than const for the brcm,bcm..
entry will prevent some churn. Up to you.

Urg so close. Thought it was a trivial change, so didn't bother
retesting the binding. I think I have it right now...

  compatible:
    oneOf:
      - items:
          - enum:
              - brcm,bcm72165-asp
              - brcm,bcm74165-asp
          - enum:
              - brcm,asp-v2.0
              - brcm,asp-v2.1

Something like this look good? Will submit a v5 tomorrow.

Thanks,
Justin

Cheers,
Conor.