Thread (4 messages) 4 messages, 3 authors, 2023-05-03

Re: [PATCH] ca8210: move to gpio descriptors

From: Stefan Schmidt <stefan@datenfreihafen.org>
Date: 2023-05-03 12:12:08
Also in: linux-gpio, lkml

Hello Arnd.

On 26.01.23 17:25, Arnd Bergmann wrote:
On Thu, Jan 26, 2023, at 17:17, Arnd Bergmann wrote:
quoted
  	if (ret) {
-		dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id);
-		gpiod_unexport(gpio_to_desc(pdata->gpio_irq));
-		gpio_free(pdata->gpio_irq);
+		dev_crit(&spi->dev, "request_irq %d failed\n", priv->irq_id);
+		gpiod_put(priv->gpio_irq);
  	}
I just realized that this bit depends on the "gpiolib: remove
legacy gpio_export" patch I sent to the gpio mailing list earlier.

We can probably just defer this change until that is merged,
or alternatively I can rebase this patch to avoid the
dependency.
I think the gpiolib ependency should be merged now. Do you want to 
rebase this patch against latest? We had some other ca8210 changes 
coming in.

regards
Stefan Schmidt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help