Thread (3 messages) flat view 3 messages, 3 authors, 2023-06-01

Re: [PATCH net-next] devlink: make health report on unregistered instance warn just once

From: Jiri Pirko <jiri@resnulli.us>
Date: 2023-05-31 06:28:13

Wed, May 31, 2023 at 03:55:23AM CEST, kuba@kernel.org wrote:
Devlink health is involved in error recovery. Machines in bad
state tend to be fairly unreliable, and occasionally get stuck
in error loops. Even with a reasonable grace period devlink health
may get a thousand reports in an hour.

In case of reporting on an unregistered devlink instance
the subsequent reports don't add much value. Switch to
WARN_ON_ONCE() to avoid flooding dmesg and fleet monitoring
dashboards.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <redacted>

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help