Thread (6 messages) flat view 6 messages, 3 authors, 2023-05-25

Re: [PATCH iproute2-next v6] ip-link: add support for nolocalbypass in vxlan

From: Vladimir Nikishkin <hidden>
Date: 2023-05-25 08:11:00

Stephen Hemminger [off-list ref] writes:
On Tue, 23 May 2023 12:48:05 +0800
Vladimir Nikishkin [off-list ref] wrote:
quoted
+	if (tb[IFLA_VXLAN_LOCALBYPASS]) {
+		__u8 localbypass = rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS]);
+
+		print_bool(PRINT_JSON, "localbypass", NULL, localbypass);
+		if (!localbypass)
+			print_bool(PRINT_FP, NULL, "nolocalbypass ", true);
+	}
This is backwards since nolocalbypass is the default.
Could you, please, look at the proposed changes again? I do not think
that the default is "nolocalbypass". The default is "localbypass", as
this is how the kernel behaved without commit
69474a8a5837be63f13c6f60a7d622b98ed5c539.

-- 
Your sincerely,
Vladimir Nikishkin (MiEr, lockywolf)
(Laptop)
--
Fastmail.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help