Re: [PATCH] vdpa: consume device_features parameter
From: Eugenio Perez Martin <eperezma@redhat.com>
Date: 2023-05-18 06:52:31
On Fri, May 12, 2023 at 6:42 PM Shannon Nelson [off-list ref] wrote:
From: Allen Hubbe <allen.hubbe@amd.com>
Consume the parameter to device_features when parsing command line
options. Otherwise the parameter may be used again as an option name.
# vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
Unknown option "0xdeadbeef"
Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
Reviewed-by: Shannon Nelson <redacted>Acked-by: Eugenio Pérez <eperezma@redhat.com>
quoted hunk ↗ jump to hunk
--- vdpa/vdpa.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c index 27647d73d498..8a2fca8647b6 100644 --- a/vdpa/vdpa.c +++ b/vdpa/vdpa.c@@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv, &opts->device_features); if (err) return err; + + NEXT_ARG_FWD(); o_found |= VDPA_OPT_VDEV_FEATURES; } else { fprintf(stderr, "Unknown option \"%s\"\n", *argv); --2.17.1