Re: [PATCH net-next v1 1/2] net: introduce and use skb_frag_fill_page_desc()

On 2023/5/9 18:07, Paolo Abeni wrote:

On Tue, 2023-05-09 at 17:26 +0800, Yunsheng Lin wrote:

quoted

Most users use __skb_frag_set_page()/skb_frag_off_set()/
skb_frag_size_set() to fill the page desc for a skb frag.

Introduce skb_frag_fill_page_desc() to do that.

net/bpf/test_run.c does not call skb_frag_off_set() to
set the offset, "copy_from_user(page_address(page), ...)"
suggest that it is assuming offset to be initialized as
zero, so call skb_frag_fill_page_desc() with offset being
zero for this case.

Also, skb_frag_set_page() is not used anymore, so remove
it.

Signed-off-by: Yunsheng Lin <redacted>

The recipients list is very long, but you forgot to include the most
relevant one: the netdev ML.

Thanks for the remainding.

Probably it's worth splitting this patch in a series with individual
patches touching the net core and the specific device drivers, to that
you could CC only the relevant recipients on each patch.

I was debugging the send_mail stript to see why the netdev ML was not
included, and ended up sending a few copy of this patchset forgeting
to use '--dry-run' option.

As there is a few Reviewed-by tags from community now, splitting this patch
might need to drop some Reviewed-by tags, which means some patch might
need re-reviewing, I am not sure it is worth splitting considering the
confusion caused by the above mistake.

Please let me know what do you think.
Thanks.