Re: [RFC PATCH net-next v6 2/5] net: Add ifreq pointer field to kernel_hwtstamp_config structure
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-05-04 03:05:47
On Mon, 1 May 2023 22:31:47 -0600 Maxim Georgiev wrote:
+ err = dev_eth_ioctl(dev, &ifrr, SIOCSHWTSTAMP);
+ if (!err) {
+ kernel_cfg->ifr->ifr_ifru = ifrr.ifr_ifru;
+ kernel_cfg->kernel_flags |= KERNEL_HWTSTAMP_FLAG_IFR_RESULT;
+ }
+ return err;nit: I think we should stick to the normal flow even if it costs a few extra lines: err = dev_eth_ioctl(.. if (err) return err; kernel_cfg->ifr->ifr_ifru = ifrr.ifr_ifru; kernel_cfg->kernel_flags |= KERNEL_HWTSTAMP_FLAG_IFR_RESULT; return 0; Other than that patches LGTM :)