Thread (1 message) 1 message, 1 author, 2023-03-06

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

From: Robin van der Gracht <robin@protonic.nl>
Date: 2023-03-06 08:17:01
Also in: alsa-devel, linux-can, linux-devicetree, linux-gpio, linux-i2c, linux-leds, linux-media, linux-pm, linux-usb, linux-wireless

From: Rob Herring <robh@kernel.org>
Date: Tue, Feb 28, 2023 at 10:54 PM
Subject: [PATCH] dt-bindings: Fix SPI and I2C bus node names in 
examples
To: Krzysztof Kozlowski <redacted>
Cc: <redacted>, Miguel Ojeda <ojeda@kernel.org>,
Benson Leung [off-list ref], Guenter Roeck
[off-list ref], Stephen Boyd [off-list ref], Andrzej Hajda
[off-list ref], Neil Armstrong [off-list ref],
Robert Foss [off-list ref], Thierry Reding
[off-list ref], Sam Ravnborg [off-list ref], MyungJoo
Ham [off-list ref], Chanwoo Choi [off-list ref],
Linus Walleij [off-list ref], Bartosz Golaszewski
[off-list ref], Pavel Machek [off-list ref], Lee Jones
[off-list ref], Mauro Carvalho Chehab [off-list ref], David S.
Miller [off-list ref], Eric Dumazet [off-list ref],
Jakub Kicinski [off-list ref], Paolo Abeni [off-list ref],
Wolfgang Grandegger [off-list ref], Kalle Valo
[off-list ref], Sebastian Reichel [off-list ref], Mark Brown
[off-list ref], Greg Kroah-Hartman [off-list ref],
[off-list ref], [off-list ref],
[off-list ref], [off-list ref],
[off-list ref], [off-list ref],
[off-list ref], [off-list ref],
[off-list ref], [off-list ref],
[off-list ref], [off-list ref]


SPI and I2C bus node names are expected to be "spi" or "i2c",
respectively, with nothing else, a unit-address, or a '-N' index. A
pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these
cases. Mostly scripted with the following commands:

git grep -l '\si2c[0-9] {' Documentation/devicetree/ | xargs sed -i -e
's/i2c[0-9] {/i2c {/'
git grep -l '\sspi[0-9] {' Documentation/devicetree/ | xargs sed -i -e
's/spi[0-9] {/spi {/'

With this, a few errors in examples were exposed and fixed.

Signed-off-by: Rob Herring <robh@kernel.org>
---
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Krzysztof Kozlowski <redacted>
Cc: Benson Leung <bleung@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Thierry Reding <redacted>
Cc: Sam Ravnborg <redacted>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Linus Walleij <redacted>
Cc: Bartosz Golaszewski <redacted>
Cc: Pavel Machek <redacted>
Cc: Lee Jones <lee@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Wolfgang Grandegger <redacted>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-clk@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-leds@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-can@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Cc: linux-usb@vger.kernel.org
---
 .../bindings/auxdisplay/holtek,ht16k33.yaml       |  2 +-
....
quoted hunk
 86 files changed, 110 insertions(+), 103 deletions(-)
diff --git 
a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
index fc4873deb76f..286e726cd052 100644
--- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
+++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
@@ -72,7 +72,7 @@ examples:
     #include <dt-bindings/interrupt-controller/irq.h>
     #include <dt-bindings/input/input.h>
     #include <dt-bindings/leds/common.h>
-    i2c1 {
+    i2c {
             #address-cells = <1>;
             #size-cells = <0>;
Acked-by: Robin van der Gracht <robin@protonic.nl>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help