Thread (29 messages) flat view 29 messages, 4 authors, 2023-03-31

Re: [PATCH 12/16] virtio_net: introduce virtnet_get_netdev()

From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Date: 2023-03-30 06:01:57
Also in: bpf, virtualization

On Wed, 29 Mar 2023 21:22:03 -0700, Jakub Kicinski [off-list ref] wrote:
On Tue, 28 Mar 2023 17:28:43 +0800 Xuan Zhuo wrote:
quoted
+const struct net_device_ops *virtnet_get_netdev(void)
+{
+	return &virtnet_netdev;
+}
Why not just make the virtnet_netdev symbol visible?
Many drivers do that.

If you prefer the function maybe virtnet_get_ndos() would be a better
name for example? The current name sounds like it will get a... well..
a netdev. And it gets ops.

Will fix.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help