Thread (79 messages) 79 messages, 7 authors, 2023-04-14

Re: [RFC PATCH v2 48/48] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)

From: David Howells <dhowells@redhat.com>
Date: 2023-03-29 14:43:46
Also in: bpf, linux-arm-msm, linux-can, linux-crypto, linux-doc, linux-fsdevel, linux-hams, linux-mm, linux-rdma, linux-sctp, lkml, mptcp, virtualization

Hannes Reinecke [off-list ref] wrote:
quoted
[!] Note: This is a work in progress.  At the moment, some things won't
     build if this patch is applied.  nvme, kcm, smc, tls.
Actually, that needs updating.  nvme and smc now build.
Weelll ... what happens to consumers of kernel_sendpage()?
(Let's call them nvme ...)
Should they be moved over, too?
Patch 42 should address NVMe, I think.  I can't test it, though, as I don't
have hardware.

There should be no callers of kernel_sendmsg() by the end of this patchset,
and the only remaining implementors of sendpage are Chelsio-TLS, AF_TLS and
AF_KCM, which as stated in the cover, aren't yet converted and won't build.
Or what is the general consensus here?

(And what do we do with TLS? It does have a ->sendpage() version, too ...)
I know.  There are three things left that I need to tackle, but I'd like to
get opinions on some of the other bits and I might need some help with AF_TLS
and AF_KCM.

That said, should I just remove tls_sw_do_sendpage() since presumably the data
is going to get copied(?) and encrypted and the source pages aren't going to
be held onto?

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help