On Fri, Mar 31, 2023 at 02:02:04PM +0530, Sricharan Ramabadhran wrote:

<..>

quoted

quoted

-static int server_del(struct qrtr_node *node, unsigned int port)
+static int server_del(struct qrtr_node *node, unsigned int port, bool bcast)
  {
  	struct qrtr_lookup *lookup;
  	struct qrtr_server *srv;

@@ -287,7 +287,7 @@ static int server_del(struct qrtr_node *node, unsigned int port)
  	radix_tree_delete(&node->servers, port);
  	/* Broadcast the removal of local servers */
-	if (srv->node == qrtr_ns.local_node)
+	if (srv->node == qrtr_ns.local_node && bcast)
  		service_announce_del(&qrtr_ns.bcast_sq, srv);
  	/* Announce the service's disappearance to observers */

@@ -373,7 +373,7 @@ static int ctrl_cmd_bye(struct sockaddr_qrtr *from)
  		}
  		slot = radix_tree_iter_resume(slot, &iter);
  		rcu_read_unlock();
-		server_del(node, srv->port);
+		server_del(node, srv->port, true);
  		rcu_read_lock();
  	}
  	rcu_read_unlock();

@@ -459,10 +459,13 @@ static int ctrl_cmd_del_client(struct sockaddr_qrtr *from,
  		kfree(lookup);
  	}
-	/* Remove the server belonging to this port */
+	/* Remove the server belonging to this port but don't broadcast

This is still not as per the multi line comment style perferred in kernel.
Please read: https://www.kernel.org/doc/html/latest/process/coding-style.html#commenting

 Ho, i had it like first style and checkpatch cribbed. Then changed it
 as per the second style for net/ format. You mean we should stick to
 1 st style ?

I think that what you have matches the preferred style for net/ code,
and thus is correct for this patch.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#multi-line-comments