Re: [BUG] net, pci: 6.3-rc1-4 hangs during boot on PowerEdge R620 with igb
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2023-03-31 19:42:57
Also in:
linux-pci, lkml
Thanks a lot for the report and for all the work you did to bisect and identify the commit. On Fri, Mar 31, 2023 at 12:40:11PM +0100, Donald Hunter wrote:
quoted hunk ↗ jump to hunk
The 6.3-rc1 and later release candidates are hanging during boot on our Dell PowerEdge R620 servers with Intel I350 nics (igb). After bisecting from v6.2 to v6.3-rc1, I isolated the problem to: [6fffbc7ae1373e10b989afe23a9eeb9c49fe15c3] PCI: Honor firmware's device disabled statusdiff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 1779582fb500..b1d80c1d7a69 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c@@ -1841,6 +1841,8 @@ int pci_setup_device(struct pci_dev *dev) pci_set_of_node(dev); pci_set_acpi_fwnode(dev); + if (dev->dev.fwnode && !fwnode_device_is_available(dev->dev.fwnode)) + return -ENODEV; pci_dev_assign_slot(dev);
I assume this igb NIC (07:00.0) must be built-in (not a plug-in card) because it apparently has an ACPI firmware node, and there's something we don't expect about its status? Hopefully Rob will look at this. If I were looking, I would be interested in acpidump to see what's in the DSDT. Bjorn