Re: [next] wifi: rtlwifi: Replace fake flex-array with flex-array member
From: Kalle Valo <kvalo@kernel.org>
Date: 2023-03-31 14:50:07
Also in:
linux-hardening, linux-wireless, lkml
From: Kalle Valo <kvalo@kernel.org>
Date: 2023-03-31 14:50:07
Also in:
linux-hardening, linux-wireless, lkml
"Gustavo A. R. Silva" [off-list ref] wrote:
Zero-length arrays as fake flexible arrays are deprecated and we are
moving towards adopting C99 flexible-array members instead.
Address the following warning found with GCC-13 and
-fstrict-flex-arrays=3 enabled:
In function ‘fortify_memset_chk’,
inlined from ‘rtl_usb_probe’ at drivers/net/wireless/realtek/rtlwifi/usb.c:1044:2:
./include/linux/fortify-string.h:430:25: warning: call to ‘__write_overflow_field’ declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
430 | __write_overflow_field(p_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].
Link: https://github.com/KSPP/linux/issues/21
Link: https://github.com/KSPP/linux/issues/277
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Simon Horman <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>Patch applied to wireless-next.git, thanks. 82d6077901c6 wifi: rtlwifi: Replace fake flex-array with flex-array member -- https://patchwork.kernel.org/project/linux-wireless/patch/ZBz4x+MWoI/f65o1@work/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches