Thread (21 messages) 21 messages, 6 authors, 2023-03-30

Re: [EXTERNAL] [PATCH 1/6] PCI: hv: fix a race condition bug in hv_pci_query_relations()

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2023-03-29 16:09:03
Also in: linux-hyperv, linux-pci, linux-rdma, lkml

On Wed, Mar 29, 2023 at 08:37:20AM +0000, Dexuan Cui wrote:
quoted
From: Bjorn Helgaas <helgaas@kernel.org>
Sent: Tuesday, March 28, 2023 10:25 AM
To: Dexuan Cui <decui@microsoft.com>
...
On Tue, Mar 28, 2023 at 05:38:59AM +0000, Dexuan Cui wrote:
quoted
quoted
From: Saurabh Singh Sengar <redacted>
Sent: Monday, March 27, 2023 10:29 PM
quoted
...
---
Please note this special line "---".
Anything after the special line and before the line "diff --git" is discarded
automaticaly by 'git' and 'patch'.
quoted
quoted
 drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
@@ -3635,6 +3641,8 @@ static int hv_pci_probe(struct hv_device *hdev,

 retry:
 	ret = hv_pci_query_relations(hdev);
+	printk("hv_pci_query_relations() exited\n");
Can we use pr_* or the appropriate KERN_<LEVEL> in all the printk(s).
This is not part of the real patch :-)
I just thought the debug code can help understand the issues
resolved by the patches.
I'll remove the debug code to avoid confusion if I need to post v2.
I guess that means you *will* post a v2, right?  
I guess I didn't make myself clear, sorry. The "debug code" is not
part of the real patch body -- if we run the "patch" program or "git am"
to apply the patches, the "debug code" is automatically dropped because
it's between the special "---" line and the real start of the patch body (i.e.
the "diff --git" line). 

So far, IMO I don't have to post v2 because the patch body and the patch
description (except for the part that's automatically removed by 'patch'
and 'git') don't need any change.
Ah, sorry, I didn't notice that, even though you explicitly pointed it
out earlier.  No need to repost just to capitalize the subject,
Lorenzo can do it or not as he chooses.

Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help