Re: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
From: Simon Horman <hidden>
Date: 2023-03-26 09:32:18
Also in:
ath11k, ath12k, linux-wireless, lkml
On Thu, Mar 23, 2023 at 07:26:12PM +0800, Cai Huoqing wrote:
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>Reviewed-by: Simon Horman <redacted>