Thread (3 messages) 3 messages, 3 authors, 2023-03-31

Re: [PATCH v2] rtlwifi: fix incorrect error codes in rtl_debugfs_set_write_reg()

From: Simon Horman <hidden>
Date: 2023-03-26 08:11:42
Also in: linux-wireless, lkml

On Sun, Mar 26, 2023 at 05:42:17AM +0000, Wei Chen wrote:
If there is a failure during copy_from_user or user-provided data buffer is
invalid, rtl_debugfs_set_write_reg should return negative error code instead
of a positive value count.

Fix this bug by returning correct error code. Moreover, the check of buffer
against null is removed since it will be handled by copy_from_user.

Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs")
Signed-off-by: Wei Chen <redacted>
Reviewed-by: Simon Horman <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help