Re: [PATCH v2 2/5] connector/cn_proc: Add filtering to fix some bugs
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-03-15 05:26:50
Also in:
lkml
On Tue, 14 Mar 2023 19:18:47 -0700 Anjali Kulkarni wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 003c7e6ec9be..ad8ec18152cd 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c@@ -63,6 +63,7 @@ #include <linux/net_namespace.h> #include <linux/nospec.h> #include <linux/btf_ids.h> +#include <linux/connector.h>
Not needed any more.
/* must not acquire netlink_table_lock in any way again before unbind
* and notifying genetlink is done as otherwise it might deadlock
*/
- if (nlk->netlink_unbind) {
+ if (nlk->netlink_unbind && nlk->groups) {Why?
int i; - for (i = 0; i < nlk->ngroups; i++) if (test_bit(i, nlk->groups)) nlk->netlink_unbind(sock_net(sk), i + 1);
Please separate the netlink core changes from the connector changes. Please slow down with new versions, we have 300 patches in the queue, replying to one version just to notice you posted a new one is frustrating. Give reviewers 24h to reply.