RE: [EXT] Re: [PATCH v9 3/3] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

From
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date
2023-03-13 14:30:54
Also in
linux-bluetooth, linux-devicetree, linux-serial, lkml
Reply to
Neeraj sanjay kale, 2023-03-13
On Mon, 13 Mar 2023, Neeraj sanjay kale wrote:
quoted
Thanks, looks okay to me except this one I just noticed while preparing this
email:
quoted
+MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
I don't think version numbers belong to the module description.
I was asked to remove the MODULE_VERSION("v1.0") line in my v2 patch, hence kept it in the description.
https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-4-neeraj.sanjaykale@nxp.com/

Please suggest me the right way to put the version string in this driver.
I think Leon meant you should just drop the version altogether (since this 
is new code).

-- 
 i.
quoted
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


--
 i.
Thank you again for reviewing this patch. :D

-Neeraj
Thread (8 messages) 8 messages, 2 authors, last reply 2023-03-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help