Hi Simon
On Fri, Mar 10, 2023 at 11:49:19PM +0530, Neeraj Sanjay Kale wrote:
quoted
Adds serdev_device_break_ctl() and an implementation for ttyport.
This function simply calls the break_ctl in tty layer, which can
assert a break signal over UART-TX line, if the tty and the underlying
platform and UART peripheral supports this operation.
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
---
v3: Add details to the commit message. (Greg KH)
...
quoted
diff --git a/include/linux/serdev.h b/include/linux/serdev.h index
66f624fc618c..c065ef1c82f1 100644
--- a/include/linux/serdev.h
+++ b/include/linux/serdev.h
...
quoted
@@ -255,6 +257,10 @@ static inline int serdev_device_set_tiocm(struct
serdev_device *serdev, int set, {
return -ENOTSUPP;
}
+static inline int serdev_device_break_ctl(struct serdev_device
+*serdev, int break_state) {
+ return -EOPNOTSUPP;
Is the use of -EOPNOTSUPP intentional here?
I see -ENOTSUPP is used elsewhere in this file.
I was suggested to use - EOPNOTSUPP instead of - ENOTSUPP by the check patch scripts and by Leon Romanovsky.
https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-2-neeraj.sanjaykale@nxp.com/
ENOTSUPP is not a standard error code and should be avoided in new patches.
See: https://lore.kernel.org/netdev/20200510182252.GA411829@lunn.ch/ (local)
quoted
+}
static inline int serdev_device_write(struct serdev_device *sdev, const
unsigned char *buf,
quoted
size_t count, unsigned long
timeout) {
--
2.34.1
Thanks,
Neeraj