Re: [PATCH v3 3/5] net: Let the active time stamping layer be selectable.

On Wed, 08 Mar 2023 10:28:51 -0500
Willem de Bruijn [off-list ref] wrote:

quoted

 
+	enum timestamping_layer selected_timestamping_layer;
+  

can perhaps be a single bit rather than an enum

I need at least two bits to be able to list the PTPs available.
Look at the ethtool_list_ptp function of the second patch.

quoted

+			err = -ENODEV;
+			WARN_ON(1);  

Please no WARN_ON on error cases that are known to be reachable
and can be handled safely and reported to userspace.

Alright, thanks.

Köry