Thread (36 messages) 36 messages, 4 authors, 2023-04-03

Re: [PATCH 5/7] dsa: marvell: Add helper function to validate the max_frame_size variable

From: "Russell King (Oracle)" <linux@armlinux.org.uk>
Date: 2023-03-09 13:21:59
Also in: lkml

On Thu, Mar 09, 2023 at 01:54:19PM +0100, Lukasz Majewski wrote:
This commit shall be regarded as a transition one, as this function helps
to validate the correctness of max_frame_size variable added to
mv88e6xxx_info structure.

It is necessary to avoid regressions as manual assessment of this value
turned out to be error prone.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Shouldn't this be patch 2 - immediately after populating the
.max_frame_size members, and before adding any additional devices?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help