Re: [PATCH net-next 1/4] vlan: Add MACsec offload operations for VLAN interface
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-03-28 22:41:59
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-03-28 22:41:59
On Tue, 28 Mar 2023 06:54:11 +0000 Emeel Hakim wrote:
quoted
quoted
+ if (real_dev->features & NETIF_F_HW_MACSEC) + features |= NETIF_F_HW_MACSEC; + return features; }Shouldn't vlan_features be consulted somehow?I did consider including the vlan_features, but after careful consideration, I couldn't see how they were relevant to the task at hand.
Decode this for me please: - what was you careful consideration - what do you think the task at hand is; and - what are vlan_features supposed to mean?