On 3/22/23 10:18 PM, Jason Wang wrote:

On Thu, Mar 23, 2023 at 3:11 AM Shannon Nelson [off-list ref] wrote:

quoted

This is the vDPA device support, where we advertise that we can
support the virtio queues and deal with the configuration work
through the pds_core's adminq.

Signed-off-by: Shannon Nelson <redacted>
---
  drivers/vdpa/pds/aux_drv.c  |  15 +
  drivers/vdpa/pds/aux_drv.h  |   1 +
  drivers/vdpa/pds/debugfs.c  | 260 +++++++++++++++++
  drivers/vdpa/pds/debugfs.h  |  10 +
  drivers/vdpa/pds/vdpa_dev.c | 560 +++++++++++++++++++++++++++++++++++-
  5 files changed, 845 insertions(+), 1 deletion(-)

diff --git a/drivers/vdpa/pds/aux_drv.c b/drivers/vdpa/pds/aux_drv.c
index 8f3ae3326885..e54f0371c60e 100644
--- a/drivers/vdpa/pds/aux_drv.c
+++ b/drivers/vdpa/pds/aux_drv.c

[...]

quoted

+
+static struct vdpa_notification_area
+pds_vdpa_get_vq_notification(struct vdpa_device *vdpa_dev, u16 qid)
+{
+       struct pds_vdpa_device *pdsv = vdpa_to_pdsv(vdpa_dev);
+       struct virtio_pci_modern_device *vd_mdev;
+       struct vdpa_notification_area area;
+
+       area.addr = pdsv->vqs[qid].notify_pa;
+
+       vd_mdev = &pdsv->vdpa_aux->vd_mdev;
+       if (!vd_mdev->notify_offset_multiplier)
+               area.size = PDS_PAGE_SIZE;

This hasn't been defined so far? Others look good.

Sorry, I don't understand your question.
sln

Thanks