On Tue, Jan 31, 2023 at 09:55:28PM -0800, Jakub Kicinski wrote:

On Tue, 31 Jan 2023 22:03:21 +0100 Heiner Kallweit wrote:

quoted

Jerome provided the information that also the GXL internal PHY doesn't
support MMD register access and EEE. MMD reads return 0xffff, what
results in e.g. completely wrong ethtool --show-eee output.
Therefore use the MMD dummy stubs.

Note: The Fixes tag references the commit that added the MMD dummy
access stubs.

Fixes: 5df7af85ecd8 ("net: phy: Add general dummy stubs for MMD register access")

Please make sure to CC the author. Adding Kevin Hao [off-list ref]

The changes look fine to me, but the using of the "Fixes" tag seems a bit weird.
The "Fixes" tag is used to specify the commit causing regression instead of patch prerequisite.

Thanks,
Kevin