On 2/17/23 14:47, Alexander Lobakin wrote:

From: Lucero Palau, Alejandro <redacted>
Date: Fri, 17 Feb 2023 10:22:36 +0000

quoted

From: Alejandro Lucero <redacted>

Adding an embarrasing missing semicolon precluding kernel building

:D

'Embarrassing' tho, with two 's'. And I guess "embarrassingly missed",
since a semicolon itself can't be "embarrassing" I believe? :D

This is going worse ... :D

I'll change it.

+ "add", not "adding"
+ "precluding"? You mean "breaking"?

Preclude: "prevent from happening; make impossible."

But I can use breaking instead.

Thanks!

quoted

in ia64 configs.

Reported-by: kernel test robot <redacted>
Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/ (local)
Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
Signed-off-by: Alejandro Lucero <redacted>
---
  drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
index d2eb6712ba35..3eb355fd4282 100644
--- a/drivers/net/ethernet/sfc/efx_devlink.c
+++ b/drivers/net/ethernet/sfc/efx_devlink.c

@@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
  				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
  		rtc_time64_to_tm(tstamp, &build_date);
  #else
-		memset(&build_date, 0, sizeof(build_date)
+		memset(&build_date, 0, sizeof(build_date);
  #endif
  		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
  

Thanks,
Olek