Thread (8 messages) 8 messages, 3 authors, 2023-02-27

Re: [PATCH v2 0/1] net: geneve: accept every ethertype

From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-02-27 19:57:46
Also in: lkml

On Mon, 27 Feb 2023 12:05:51 +0200 Eyal Birger wrote:
quoted
quoted
This seems like an addition not a bugfix so personally seems like it should
be targeting net-next (which is currently closed afaik).  
One could say the receive function should have behaved like that, the
transmit function already encapsulates every possible Ethertype and
IFLA_GENEVE_INNER_PROTO_INHERIT doesn't sound like it should be limited to
IPv4 and IPv6.  
Indeed the flag is intentionally generic to allow for future extensions
without having to rename. But both in the commit message, and in the iproute2
man page I noted support for IPv4/IPv6.
quoted
If no further modifications down the packet chain are required, I'd say it's
50/50. However I haven't contributed to the Linux kernel ever before, so I
really have no clue as to how things go.
I think net-next is a better target, Eyal's explanation that the check
is intentional seems quite reasonable. FWIW, when you repost feel free
to fold the info from the cover letter into the patch description. 
With a single patch cover letters just split the info unnecessarily.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help