Re: [PATCH net-next v8 5/9] net: phy: add genphy_c45_ethtool_get/set_eee() support
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2023-02-27 05:53:10
Also in:
intel-wired-lan, linux-amlogic, linux-arm-kernel, lkml
Hi Mark, On Sun, Feb 26, 2023 at 06:06:48PM +0000, Mark Brown wrote:
On Sat, Feb 11, 2023 at 08:41:09AM +0100, Oleksij Rempel wrote:quoted
Add replacement for phy_ethtool_get/set_eee() functions. Current phy_ethtool_get/set_eee() implementation is great and it is possible to make it even better: - this functionality is for devices implementing parts of IEEE 802.3 specification beyond Clause 22. The better place for this code is phy-c45.cCurrently mainline is failing to bring up networking on the Libre Computer AML-S905X-CC, with a bisect pointing at this commit, 022c3f87f88 upstream (although I'm not 100% sure I trust the bisect it seems to be in roughly the right place). I've not dug into what's going on more than running the bisect yet.
Can you please test following fixes: https://lore.kernel.org/all/167715661799.11159.2057121677394149658.git-patchwork-notify@kernel.org/ (local) https://lore.kernel.org/all/20230225071644.2754893-1-o.rempel@pengutronix.de/ (local) Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |