Re: [PATCH net-next v2 0/4] net: phy: EEE fixes

On Tue, Feb 21, 2023 at 10:48:09AM +0100, Oleksij Rempel wrote:

On Tue, Feb 21, 2023 at 09:36:35AM +0000, Russell King (Oracle) wrote:

quoted

On Tue, Feb 21, 2023 at 06:03:30AM +0100, Oleksij Rempel wrote:

quoted

changes v2:
- restore previous ethtool set logic for the case where advertisements
  are not provided by user space.

I don't think the _kernel_ should be doing this - this introduces a
different behaviour to the kernel. As I already said, setting the
default advertisement in the case of ethtool -s is done by userspace
not by the kernel.

In fact, the kernel explicitly rejects an attempt to have autoneg
enabled with a zero advertising mask:

        linkmode_copy(advertising, cmd->link_modes.advertising);
        linkmode_and(advertising, advertising, phydev->supported);
        if (autoneg == AUTONEG_ENABLE && linkmode_empty(advertising))
                return -EINVAL;

and I think we should have a uniform behaviour with the same API,
rather than different behaviours, as that becomes quite messy.

I decided to revert this part to not mix different issue. This logic
existed before my refactoring. So, it is better to handle it as
different patch. Current patch set should address only regressions.

Okay, let's keep it like that then. Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!