Thread (20 messages) flat view 20 messages, 4 authors, 2023-03-13
STALE1288d LANDED: 1 (0M)

Revision v3 of 6 in this series; 1 review trailer; landed in mainline as a00da30c052f on 2023-02-21.

Revisions (6)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 current
  4. v4 [diff vs current]
  5. v1 [diff vs current]
  6. v2 [diff vs current]

[PATCH v3 net-next 01/13] net: ethtool: fix __ethtool_dev_mm_supported() implementation

From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2023-02-20 12:24:08
Also in: lkml
Subsystem: networking [ethtool mac merge], networking [ethtool], networking [general], the rest · Maintainers: Vladimir Oltean, Andrew Lunn, Jakub Kicinski, "David S. Miller", Eric Dumazet, Paolo Abeni, Linus Torvalds

The MAC Merge layer is supported when ops->get_mm() returns 0.
The implementation was changed during review, and in this process, a bug
was introduced.

Link: https://lore.kernel.org/netdev/20230111161706.1465242-5-vladimir.oltean@nxp.com/ (local)
Fixes: 04692c9020b7 ("net: ethtool: netlink: retrieve stats from multiple sources (eMAC, pMAC)")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ferenc Fejes <redacted>
---
v2->v3: change link from patchwork to lore
v1->v2: none

 net/ethtool/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/mm.c b/net/ethtool/mm.c
index e612856eed8c..fce3cc2734f9 100644
--- a/net/ethtool/mm.c
+++ b/net/ethtool/mm.c
@@ -247,5 +247,5 @@ bool __ethtool_dev_mm_supported(struct net_device *dev)
 	if (ops && ops->get_mm)
 		ret = ops->get_mm(dev, &state);
 
-	return !!ret;
+	return !ret;
 }
-- 
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help