Thread (35 messages) 35 messages, 10 authors, 2023-02-20

Re: [PATCH v2 1/1] ice: Change assigning method of the CPU affinity masks

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-02-16 15:16:31
Also in: linux-crypto, linux-rdma, lkml

On Thu, Feb 16, 2023 at 05:14:33PM +0200, Andy Shevchenko wrote:
On Thu, Feb 16, 2023 at 03:54:55PM +0100, Pawel Chmielewski wrote:
...
quoted
+		for_each_cpu_andnot(cpu, aff_mask, last_aff_mask) {
+			if (v_idx >= vsi->num_q_vectors)
quoted
+				goto out;
Useless. You can return 0; here.
quoted
+		}
Btw, I briefly checked the other functions nearby in the code and none of them
is using goto for OK cases.


-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help