Re: [PATCH net-next v1 7/7] net: fec: add support for PHYs with SmartEEE support
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-02-16 12:50:16
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2023-02-16 12:50:16
Also in:
lkml
I would prefer to not touch phy_init_eee(). At least not in this patch set. With this function we have following situation:
We have a complete mess :-( I spent yesterday re-writing the MAC driver side of EEE. Most get it completely wrong, as you point out. So i changed the API a bit, making it more like other negotiated things, so i hope developers will get it correct in the future. I will post an RFC/RFT series soon.
Hm.. I need to admit, EEE should not be advertised by default. Only if MAC driver calls something like phy_support_eee(), we should start doing it.
This i've not looked at yet. But i agree.
Andrew