Re: [PATCH v4 05/21] net/tcp: Calculate TCP-AO traffic keys
From: kernel test robot <hidden>
Date: 2023-02-15 22:51:20
Also in:
lkml, oe-kbuild-all
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on e1c04510f521e853019afeca2a5991a5ef8d6a5b] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836 base: e1c04510f521e853019afeca2a5991a5ef8d6a5b patch link: https://lore.kernel.org/r/20230215183335.800122-6-dima%40arista.com patch subject: [PATCH v4 05/21] net/tcp: Calculate TCP-AO traffic keys config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230216/202302160619.lvY45Sx5-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/e93c86e7edccffd9992748d03591579a4ebc2731 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dmitry-Safonov/net-tcp-Prepare-tcp_md5sig_pool-for-TCP-AO/20230216-023836 git checkout e93c86e7edccffd9992748d03591579a4ebc2731 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash net/ipv4/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot [off-list ref] | Link: https://lore.kernel.org/oe-kbuild-all/202302160619.lvY45Sx5-lkp@intel.com/ (local) All warnings (new ones prefixed by >>): net/ipv4/tcp_ao.c:59:20: warning: no previous prototype for 'tcp_ao_matched_key' [-Wmissing-prototypes] 59 | struct tcp_ao_key *tcp_ao_matched_key(struct tcp_ao_info *ao, | ^~~~~~~~~~~~~~~~~~
quoted
net/ipv4/tcp_ao.c:245:5: warning: no previous prototype for 'tcp_ao_calc_key_sk' [-Wmissing-prototypes]
245 | int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
| ^~~~~~~~~~~~~~~~~~
vim +/tcp_ao_calc_key_sk +245 net/ipv4/tcp_ao.c
244
> 245 int tcp_ao_calc_key_sk(struct tcp_ao_key *mkt, u8 *key,
246 const struct sock *sk,
247 __be32 sisn, __be32 disn,
248 bool send)
249 {
250 if (mkt->family == AF_INET)
251 return tcp_v4_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
252 else
253 return tcp_v6_ao_calc_key_sk(mkt, key, sk, sisn, disn, send);
254 }
255
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests