Re: [PATCH v2 net-next] net: no longer support SOCK_REFCNT_DEBUG feature
From: Matthieu Baerts <hidden>
Date: 2023-02-15 09:40:14
Also in:
bpf, linux-s390, linux-sctp, lkml, mptcp
Hi Jason, On 14/02/2023 05:14, Jason Xing wrote:
From: Jason Xing <kernelxing@tencent.com>
Commit e48c414ee61f ("[INET]: Generalise the TCP sock ID lookup routines")
commented out the definition of SOCK_REFCNT_DEBUG in 2005 and later another
commit 463c84b97f24 ("[NET]: Introduce inet_connection_sock") removed it.
Since we could track all of them through bpf and kprobe related tools
and the feature could print loads of information which might not be
that helpful even under a little bit pressure, the whole feature which
has been inactive for many years is no longer supported.
Link: https://lore.kernel.org/lkml/20230211065153.54116-1-kerneljasonxing@gmail.com/ (local)
Suggested-by: Kuniyuki Iwashima <redacted>
Signed-off-by: Jason Xing <kernelxing@tencent.com>(...)
quoted hunk ↗ jump to hunk
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 8cd6cc67c2c5..e913752df112 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c@@ -2876,7 +2876,6 @@ static void __mptcp_destroy_sock(struct sock *sk) sk_stream_kill_queues(sk); xfrm_sk_free_policy(sk); - sk_refcnt_debug_release(sk); sock_put(sk); }
Thank you for the patch! For the modification in MPTCP subtree: Acked-by: Matthieu Baerts <redacted> Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net