RE: [EXT] [PATCH] octeontx2-pf: Remove repeating variable in test

-----Original Message-----
From: Deepak R Varma <redacted>
Sent: Saturday, February 11, 2023 3:16 PM
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
[off-list ref]; Subbaraya Sundeep Bhatta [off-list ref];
Hariprasad Kelam [off-list ref]; David S. Miller
[off-list ref]; Eric Dumazet [off-list ref]; Jakub
Kicinski [off-list ref]; Paolo Abeni [off-list ref];
netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Saurabh Singh Sengar <redacted>; Praveen Kumar
[off-list ref]; Deepak R Varma [off-list ref]
Subject: [EXT] [PATCH] octeontx2-pf: Remove repeating variable in test

External Email

----------------------------------------------------------------------
No need to & a variable with itself. Remove extra variable from the expression.
Change allows to realign code and improve readability.
Issue identified using doublebitand.cocci Coccinelle semantic patch.

Signed-off-by: Deepak R Varma <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c

b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
index 684cb8ec9f21..66a27ee5ca56 100644

--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_flows.c

@@ -792,8 +792,7 @@ static int otx2_prepare_ipv6_flow(struct

ethtool_rx_flow_spec *fsp,
 		}

 		/* NPC profile doesn't extract AH/ESP header fields */
-		if ((ah_esp_mask->spi & ah_esp_hdr->spi) ||
-		    (ah_esp_mask->tclass & ah_esp_mask->tclass))
+		if ((ah_esp_mask->spi & ah_esp_hdr->spi) || ah_esp_mask-

quoted

tclass)