Thread (6 messages) 6 messages, 3 authors, 2023-02-08

Re: [PATCH -next] net: bridge: clean up one inconsistent indenting

From: Nikolay Aleksandrov <razor@blackwall.org>
Date: 2023-02-08 13:31:55
Also in: bridge, lkml

On 2/8/23 15:30, Nikolay Aleksandrov wrote:
On 2/8/23 15:04, Simon Horman wrote:
quoted
On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
quoted
./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with 
following code on line 318

Reported-by: Abaci Robot <redacted>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
Signed-off-by: Yang Li <redacted>
As you may need to respin this:

Assuming this is targeting net-next, which seems likely to me,
the subject should denote that. Something like this:

[PATCH net-next] net: bridge: clean up one inconsistent indenting
quoted
---
  net/bridge/br_netlink_tunnel.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink_tunnel.c 
b/net/bridge/br_netlink_tunnel.c
index 17abf092f7ca..eff949bfdd83 100644
--- a/net/bridge/br_netlink_tunnel.c
+++ b/net/bridge/br_netlink_tunnel.c
@@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct 
net_bridge *br,
              if (curr_change)
                  *changed = curr_change;
-             __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
+            __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
                              curr_change);
I think you also need to adjust the line immediately above.
You meant below, right? :) i.e. "curr_change)", that seems to get
misaligned after the change and needs to be adjusted as well.
Oh I need coffee, I somehow was thinking about the line being changed
instead of literally the line above your statement. :))

Anyway, ack.
quoted
quoted
          }
          if (v_start && v_end)
-- 
2.20.1.7.g153144c
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help