-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Natalia Petrova
Sent: Wednesday, February 1, 2023 2:36 PM
To: Brandeburg, Jesse <redacted>
Cc: lvc-project@linuxtesting.org; intel-wired-lan@lists.osuosl.org; Natalia
Petrova [off-list ref]; linux-kernel@vger.kernel.org; Eric
Dumazet [off-list ref]; Nguyen, Anthony L
[off-list ref]; netdev@vger.kernel.org; Jakub Kicinski
[off-list ref]; Paolo Abeni [off-list ref]; David S. Miller
[off-list ref]
Subject: [Intel-wired-lan] [PATCH v3] i40e: Add checking for null for
nlmsg_find_attr()

The result of nlmsg_find_attr() 'br_spec' is dereferenced in
nla_for_each_nested(), but it can take NULL value in nla_find() function,
which will result in an error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
Signed-off-by: Natalia Petrova <redacted>
Reviewed-by: Jesse Brandeburg <redacted>
---
v3: Fixed mailing list.
v2: The remark about the error code by Simon Horman
[off-list ref] was taken into account; return value -
ENOENT was changed to -EINVAL.
 drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
 1 file changed, 2 insertions(+)

Tested-by: Gurucharan G <redacted> (A Contingent worker at Intel)