Re: [PATCH net] net: phylink: move phy_device_free() to correctly release phy device
From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-02-03 10:00:30
Also in:
lkml
From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-02-03 10:00:30
Also in:
lkml
Hello: This patch was applied to netdev/net.git (master) by David S. Miller [off-list ref]: On Tue, 31 Jan 2023 11:02:42 +0100 you wrote:
After calling fwnode_phy_find_device(), the phy device refcount is incremented. Then, when the phy device is attached to a netdev with phy_attach_direct(), the refcount is also incremented but only decremented in the caller if phy_attach_direct() fails. Move phy_device_free() before the "if" to always release it correctly. Indeed, either phy_attach_direct() failed and we don't want to keep a reference to the phydev or it succeeded and a reference has been taken internally. [...]
Here is the summary with links:
- [net] net: phylink: move phy_device_free() to correctly release phy device
https://git.kernel.org/netdev/net/c/ce93fdb5f2ca
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html