[PATCH net-next v4 2/9] net/sched: act_pedit, setup offload action for action stats query
STALE1329d
REVIEWED: 2 (1M)
From: Oz Shlomo <hidden>
Date: 2023-02-12 13:26:05
Subsystem:
networking [general], tc subsystem, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Jamal Hadi Salim, Jiri Pirko, Linus Torvalds
Revision v4 of 3 in this series; 2 review trailers.
Revisions (3)
- v2 [diff vs current]
- v3 [diff vs current]
- v4 current
A single tc pedit action may be translated to multiple flow_offload
actions.
Offload only actions that translate to a single pedit command value.
Signed-off-by: Oz Shlomo <redacted>
Reviewed-by: Simon Horman <redacted>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
Change log:
V1 -> V2:
- Add extack message on error
- Assign the flow action id outside the for loop.
Ensure the rest of the pedit actions follow the assigned id.
V2 -> V3:
- Fix last_cmd initialization
V3 -> V4:
- Compare all action types to the first action
---
net/sched/act_pedit.c | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index c42fcc47dd6d..35ebe5d5c261 100644
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c@@ -545,7 +545,28 @@ static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data, } *index_inc = k; } else { - return -EOPNOTSUPP; + struct flow_offload_action *fl_action = entry_data; + u32 cmd = tcf_pedit_cmd(act, 0); + int k; + + switch (cmd) { + case TCA_PEDIT_KEY_EX_CMD_SET: + fl_action->id = FLOW_ACTION_MANGLE; + break; + case TCA_PEDIT_KEY_EX_CMD_ADD: + fl_action->id = FLOW_ACTION_ADD; + break; + default: + NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload"); + return -EOPNOTSUPP; + } + + for (k = 1; k < tcf_pedit_nkeys(act); k++) { + if (cmd != tcf_pedit_cmd(act, k)) { + NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload"); + return -EOPNOTSUPP; + } + } } return 0;
--
1.8.3.1