Re: [PATCH net-next v4] gve: Introduce a way to disable queue formats

From
Jakub Kicinski <kuba@kernel.org>
Date
2023-02-07 06:50:24
Reply to
Jeroen de Borst, 2023-02-04
On Sat,  4 Feb 2023 11:29:40 -0800 Jeroen de Borst wrote:
The device is capable of simultaneously supporting multiple
queue formats. These queue formats are:

- GQI-QPL: A queue format with in-order completions and a
bounce-buffer (Queue Page List)
- GQI-RDA: A queue format with in-order completions and no
bounce-buffer (Raw DMA Access)
- DQO-RDA: A queue format with out-of-order completions and
no bounce buffer
Thanks but..
With this change the driver can deliberately pick a queue format.
Driver can already do whatever it wants. Now the _user_ can pick 
the format. But the user still has no understanding of what the
practical impact of picking one queue format over another will be.
Do you have a reason to believe that the description above (and in 
docs) will be sufficient for user to make a decision? 

I tried to search the web but got no hits to any GCP docs either.

Differently put what is you motivation to give this control to the user?
quoted hunk ↗ jump to hunk
+
+struct bpf_prog;
 static int gve_verify_driver_compatibility(struct gve_priv *priv)
Adding the forward declaration for bpf_prog looks like a stray change.
Thread (2 messages) 2 messages, 2 authors, last reply 2023-02-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help