Re: [PATCH net-next mlxsw v2 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries

Nikolay Aleksandrov [off-list ref] writes:

On 02/02/2023 10:52, Nikolay Aleksandrov wrote:

quoted

On 01/02/2023 19:28, Petr Machata wrote:

quoted

+int br_multicast_vlan_ngroups_set_max(struct net_bridge *br,
+				      struct net_bridge_vlan *v, u32 max,
+				      struct netlink_ext_ack *extack)
+{
+	if (br_multicast_port_ctx_vlan_disabled(&v->port_mcast_ctx)) {
+		NL_SET_ERR_MSG_MOD(extack, "Multicast snooping disabled on this VLAN");
+		return -EINVAL;
+	}

same comment about the check

Ok, not exactly the same. I see that for the max case this check is used, please pull it
in the vlan code and just drop this helper. Both read/write will be doing the same then.

OK. This actually simplifies the code quite a bit.