Thread (3 messages) 3 messages, 3 authors, 2023-02-01

Re: [PATCH net] sctp: do not check hb_timer.expires when resetting hb_timer

From: patchwork-bot+netdevbpf@kernel.org
Date: 2023-02-01 05:10:27
Also in: linux-sctp

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski [off-list ref]:

On Mon, 30 Jan 2023 11:25:33 -0500 you wrote:
It tries to avoid the frequently hb_timer refresh in commit ba6f5e33bdbb
("sctp: avoid refreshing heartbeat timer too often"), and it only allows
mod_timer when the new expires is after hb_timer.expires. It means even
a much shorter interval for hb timer gets applied, it will have to wait
until the current hb timer to time out.

In sctp_do_8_2_transport_strike(), when a transport enters PF state, it
expects to update the hb timer to resend a heartbeat every rto after
calling sctp_transport_reset_hb_timer(), which will not work as the
change mentioned above.

[...]
Here is the summary with links:
  - [net] sctp: do not check hb_timer.expires when resetting hb_timer
    https://git.kernel.org/netdev/net/c/8f35ae17ef56

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help