Thread (1 message) 1 message, 1 author, 2023-01-04

Re: [PATCH V2 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration

From: Bjørn Mork <bjorn@mork.no>
Date: 2023-01-04 20:24:09
Also in: linux-usb

Matthew Garrett [off-list ref] writes:
quoted hunk
The Orbic Speed RC400L presents as a generic MDM9207 device that supports
multiple configurations with different USB IDs. One exposes a QMI interface.
Add the ID for that.

Signed-off-by: Matthew Garrett <redacted>
---
 drivers/net/usb/qmi_wwan.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index a808d718c012..bf05b7feacc0 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1223,6 +1223,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x90b2, 3)},    /* ublox R410M */
 	{QMI_FIXED_INTF(0x05c6, 0x920d, 0)},
 	{QMI_FIXED_INTF(0x05c6, 0x920d, 5)},
+	{QMI_FIXED_INTF(0x05c6, 0xf601, 5)},
 	{QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)},	/* YUGA CLM920-NC5 */
 	{QMI_FIXED_INTF(0x0846, 0x68a2, 8)},
 	{QMI_FIXED_INTF(0x0846, 0x68d3, 8)},	/* Netgear Aircard 779S */

Looks good to me, but checkpatch warns about

 WARNING: From:/Signed-off-by: email address mismatch: 'From: Matthew Garrett [off-list ref]' != 'Signed-off-by: Matthew Garrett [off-list ref]'

which you might want to consider, unless this was intentional for some
reason?  In any case:

Acked-by: Bjørn Mork <bjorn@mork.no>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help