Re: [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason
From: Jakub Kicinski <kuba@kernel.org>
Date: 2023-01-25 19:02:35
Also in:
intel-wired-lan, linux-doc
On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote:
- err = dev->xfrmdev_ops->xdo_dev_policy_add(xp);
+ err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack);
if (err) {
xdo->dev = NULL;
xdo->real_dev = NULL;
xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED;
xdo->dir = 0;
netdev_put(dev, &xdo->dev_tracker);
- NL_SET_ERR_MSG(extack, "Device failed to offload this policy");In a handful of places we do: if (!extack->msg) NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); in case the device did not provide the extack. Dunno if it's worth doing here.