Re: [PATCH v2 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support
From: Krzysztof Kozlowski <hidden>
Date: 2023-01-31 19:05:20
Also in:
linux-bluetooth, linux-devicetree, linux-serial, lkml
On 30/01/2023 19:05, Neeraj Sanjay Kale wrote:
quoted hunk ↗ jump to hunk
Add binding document for generic and legacy NXP bluetooth chipsets. Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- v2: Resolved dt_binding_check errors. (Rob Herring) v2: Modified description, added specific compatibility devices, corrected indentations. (Krzysztof Kozlowski) --- .../bindings/net/bluetooth/nxp-bluetooth.yaml | 40 +++++++++++++++++++ MAINTAINERS | 6 +++ 2 files changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yamldiff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml new file mode 100644 index 000000000000..9c8a25396b49 --- /dev/null +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
Filename based on family of devices or compatible (assuming it is correct): nxp,w8987-bt.yaml Hyphen is not a correct separator between vendor prefix and device name.
quoted hunk ↗ jump to hunk
@@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/bluetooth/nxp-bluetooth.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP Bluetooth chips + +description: + This binding describes UART-attached NXP bluetooth chips.
This is description of binding. So in description of binding for NXP bluetooth chips you say that it describes NXP bluetooth chips. I don't think it's useful. Describe the hardware instead.
+ +maintainers: + - Neeraj Sanjay Kale [off-list ref] + +properties: + compatible: + enum: + - nxp,w8987-bt + - nxp,w8997-bt + - nxp,w9098-bt + - nxp,iw416-bt + - nxp,iw612-bt
Why "bt" suffix? Are these chips coming with other functions? Best regards, Krzysztof