Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer

Hi Jakub,

sorry for late response, please check following reply.

On Thu, 2023-01-19 at 19:52 -0800, Jakub Kicinski wrote:

On Wed, 18 Jan 2023 19:38:55 +0800 Yanchao Yang wrote:

quoted

 drivers/net/wwan/mediatek/mtk_dpmaif.c     | 4005
++++++++++++++++++++

clang detects out-of-bound memcpy/strcpy or such somewhere in this
file.
Please fix that.

Ok, we will check and fix it.

Please try to make the series smaller than 17,770 :/
Strip stuff down to minimal working version.
I don't think anyone can review 17kLoC in one sitting :/

Thank your suggestion. I agree with you. Considering both the control
plane and data plane are the minimal function for TMI driver, other
functions can be removed and submitted after the initial version is
approved. The whole patch can be reduced about 2k lines. Is it ok? Or
do you have any more suggestions? Please help share it.

Many thanks.
yanchao.yang