Re: [PATCH 0/2] net: stmmac: add DT parameter to keep RX_CLK running in LPI state

On 25.01.2023 22:14, Rob Herring wrote:

On Tue, Jan 24, 2023 at 03:09:50PM +0100, Andrew Lunn wrote:

quoted

quoted

quoted

Could
dwmac-qcom-ethqos.c just do this unconditionally?

Never stopping RX_CLK in Rx LPI state would always work, but the power
consumption would somewhat increase (in Rx LPI state). Some people do care
about it.

quoted

Is the interrupt
controller part of the licensed IP, or is it from QCOM? If it is part
of the licensed IP, it is probably broken for other devices as well,
so maybe it should be a quirk for all devices of a particular version
of the IP?

Most probably this is the part of the ethernet MAC IP. And this is quite
possible that the issue is specific for particular versions of the IP.
Unfortunately I don't have the documentation related to this particular
issue.

Please could you ask around.

I am on it, but it will take time.

quoted

Do you have contacts in Qualcomm?
Contacts at Synopsys?

In Qualcomm only I am afraid.

quoted

Ideally it would be nice to fix it for everybody, not just one SoC.

Yes, but to fix for just 1 SoC use the SoC specific compatible to imply
the need for this. Then only a kernel update is needed to fix, not a
kernel and dtb update.

That's good point! Thanks!

I've just posted such 1 SoC only version:
https://lore.kernel.org/lkml/20230126213539.166298-1-andrey.konovalov@linaro.org/T/#t (local)
In case this is a more proper way to go.

Rob

Thanks,
Andrey