Thread (3 messages) 3 messages, 3 authors, 2023-01-26

Re: [PATCH] wiznet: convert to GPIO descriptors

From: "Arnd Bergmann" <arnd@arndb.de>
Date: 2023-01-26 18:42:03
Also in: linux-devicetree, linux-gpio, lkml

On Thu, Jan 26, 2023, at 19:14, Leon Romanovsky wrote:
On Thu, Jan 26, 2023 at 02:54:12PM +0100, Arnd Bergmann wrote:
quoted
 
@@ -139,6 +139,12 @@ MODULE_LICENSE("GPL");
 #define W5500_RX_MEM_START	0x30000
 #define W5500_RX_MEM_SIZE	0x04000
 
+#ifndef CONFIG_WIZNET_BUS_SHIFT
+#define CONFIG_WIZNET_BUS_SHIFT 0
+#endif
I don't see any define of CONFIG_WIZNET_BUS_SHIFT in the code, so it looks
like it always zero and can be removed.
Good catch! Evidently the original idea was that this would
be set to a machine specific value through Kconfig. I've renamed
the constant, removed the #ifdef and explained it in the changelog
text now.

     Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help