RE: [Intel-wired-lan] [PATCH 9/9] ixgbe: Remove redundant pci_enable_pcie_error_reporting()

-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Bjorn Helgaas
Sent: Thursday, January 19, 2023 5:16 AM
To: linux-pci@vger.kernel.org
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
Jesse [off-list ref]; intel-wired-lan@lists.osuosl.org; Bjorn
Helgaas [off-list ref]; Nguyen, Anthony L
[off-list ref]
Subject: [Intel-wired-lan] [PATCH 9/9] ixgbe: Remove redundant
pci_enable_pcie_error_reporting()

From: Bjorn Helgaas <bhelgaas@google.com>

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this doesn't control interrupt generation by the Root Port; that is
controlled by the AER Root Error Command register, which is managed by the
AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <redacted>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 -----
 1 file changed, 5 deletions(-)

Tested-by: Gurucharan G <redacted> (A Contingent worker at Intel)